[Asterisk-code-review] STIR/SHAKEN: Option split and response codes. (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Benjamin Keith Ford.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16497 )

Change subject: STIR/SHAKEN: Option split and response codes.
......................................................................


Patch Set 4:

(3 comments)

File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/16497/comment/234acaa1_eec23d2c 
PS3, Line 4070: ast_sip_rdata_get_header_value
> Commented on this in other thread. Feel free to correct my thinking if it's wrong.
Ack


File res/res_pjsip_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/16497/comment/0dce89c8_32a1ba86 
PS3, Line 140: 	sscanf(remainder, "%79s", timezone);
> Yeah I believe checking the result is sufficient, and something you'd want to do either way. […]
Done


File res/res_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/16497/comment/83d112e6_989195dc 
PS4, Line 749: struct ast_stir_shaken_payload *ast_stir_shaken_verify(const char *header, const char *payload, const char *signature,
             : 	const char *algorithm, const char *public_cert_url)
             : {
Not really a bug, but since this function and verify2 appear to be identical except for the added return code, you can just have this function call verify2 to reduce redundant code.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16497
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4ac1ecf652cd0e336006b0ca638dc826b5b1ebf7
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Tue, 19 Oct 2021 17:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211019/54dd822a/attachment.html>