[Asterisk-code-review] chan_sip: Add custom SIP parameter capabilities (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16569 )

Change subject: chan_sip: Add custom SIP parameter capabilities
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
The chan_sip module is slated for removal as of Asterisk 21, so while this patch may solve your problem for now it will eventually go away. Every chan_sip patch, even something like this, also ends up having a high chance of causing an unintended regression or issue (I haven't looked at the patch but it's substantial usually). Reviewing new feature patches for modules with a removal timeline like this also consume time which could be used elsewhere.

Personally I don't think it is worthwhile for the project to review and accept such things any longer.

Any thoughts from others?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16569
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1e99a220295c03275827050147622a6c1f5a4be9
Gerrit-Change-Number: 16569
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 11 Oct 2021 14:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211011/2072486a/attachment.html>