[Asterisk-code-review] progdocs: Fix grouping for latest Doxygen. (asterisk[master])

[Joshua Colp]

Attention is currently required from: Kevin Harwell, Alexander Traud.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17334 )

Change subject: progdocs: Fix grouping for latest Doxygen.
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> > I don't see the harm in minor breakages to that opinion. […]
I think fundamentally Alexander you have a different view of how the interaction and experience should be for code reviews and the Asterisk project, that differ from everyone else. Your view is much more rigid and you believe that you should only have to do X and the experience should be a certain way. That other people should behave and review as you want, and that Sangoma and other Asterisk members should do things a certain way and do certain things in the project. In reality, it's not that way and I don't think it ever will be.

For everyone else we treat this as a group effort, one of discussion, helping each other out, progressing the project. We aren't as strict, we don't have as defined roles. It's everyone working together.

For code reviews in general the goal of reviewers is to progress the project and get the change into a state where it can be merged. That is something that shouldn't be compromised on, and I truly believe that any and all comments should be posted in a way which is visible to the contributor. Even in the past a minor comment along the lines of "you can do this if you wish" has yielded the discovery of an issue by someone else that does need fixing. The key is reasonable discussion as a result of it. This is not something that should be frowned upon, and it should be expected with every code review. Putting a code review up does not shift full burden to the project and does not mean it will or should be accepted, it's a two way interaction. That being said people will absolutely take over reviews at times if the person is uncomfortable or doesn't have time. There just has to be reasonable communication as such. This is something that contributors have reached out to me privately about, that they were appreciative of the process, the help they received, the comments. They certainly wanted the change to go in quickly but after going through code review that uncovered things they understood why and learned things along the way.

As for your 650 projects comment. Undertaking such an action was your choice, a choice that has consequences such as having to interact with the projects. Your choice doesn't mean that the projects have to respond in the way you desire and in my opinion is not a reason to not have discussion regarding changes. In the end everyone is busy, and everyone's time is valuable.

I'd also like to touch on Gerrit and process briefly. If help is needed or questions about it occur such as the best way to update a review, then they can certainly be brought up on the asterisk-dev mailing list or IRC. We have actively helped people in the last few weeks who had issues or questions.

In regards to using 0 and not marking stuff as -1 I've tried this before. This rarely works, because people don't notice or see the comment so it is generally the equivalent of not commenting at all. A -1 is much more likely to garner attention, and can always be removed by the person who put it there.

As for the mentioned wiki page. To the best of my knowledge there has never been a wiki page telling people they can't "argue". There is a code of conduct[1] which is for acceptable behavior, but that doesn't prevent discussion and arguments. 

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Community+Code+of+Conduct



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17334
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4687857b9d56e6f44fd440b73af156691660202e
Gerrit-Change-Number: 17334
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Tue, 30 Nov 2021 11:17:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Alexander Traud <pabstraud at compuserve.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211130/e59d4073/attachment.html>