[Asterisk-code-review] res: Fix for Doxygen. (asterisk[master])

Josh Soref asteriskteam at digium.com
Wed Nov 24 17:36:38 CST 2021


Attention is currently required from: George Joseph, Alexander Traud.
Josh Soref has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17511 )

Change subject: res: Fix for Doxygen.
......................................................................


Patch Set 4:

(3 comments)

Patchset:

PS4: 
The blank line question is generic


File include/asterisk/http_websocket.h:

https://gerrit.asterisk.org/c/asterisk/+/17511/comment/7a9810ea_d116d232 
PS4, Line 224:  * \param server Name of the sub-protocol to unregister
Same comment as before (sorry, should have commented on all of them)


https://gerrit.asterisk.org/c/asterisk/+/17511/comment/a256a70c_72568533 
PS4, Line 258:  * \return number of bytes read on success
General question: is there a convention to have a blank line between `\param` and one of `\retval` or `\return`? The items above seem to, and some below, but not this, and not others below.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17511
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I572e6019c422780dde5ce8448b6c85c77af6046d
Gerrit-Change-Number: 17511
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Josh Soref <jsoref at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Wed, 24 Nov 2021 23:36:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211124/42cd05de/attachment.html>


More information about the asterisk-code-review mailing list