[Asterisk-code-review] global: Spelling fixes (asterisk[master])

Tue Nov 16 23:41:20 CST 2021

Josh Soref has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17502 )

Change subject: global: Spelling fixes
......................................................................

Patch Set 1:

(27 comments)

File CREDITS:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/2848be7d_e0f28555 
PS1, Line 202: 		mailbox in voicemail.  Also an issue with voicemail 
i presume the pink here is trailing whitespace. I try not to do more than what it says on the tin, but if there's a policy about whitespace...

File Makefile:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/434e2348_b7ea9f3c 
PS1, Line 761: install: install
I meant to drop this

File apps/app_minivm.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/882a78d1_324e8b7f 
PS1, Line 2957: 	if ((chanvar = ast_variable_retrieve(cfg, "general", "emailaddress")))
Oops, this shouldn't be here (the next if covers it)

File channels/chan_iax2.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/363bb10f_b339d39c 
PS1, Line 5852: 	const struct ast_channel *requestor, unsigned int cacheable)
If the `cacheable` changes are annoying, I can drop them

File channels/chan_skinny.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/297411ec_351f5f35 
PS1, Line 716: #define SOFTKEY_TRANSFER 0x04
Calling this (and its sibling) out in case they're interesting

File channels/chan_unistim.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/69c17c31_e27f0fd7 
PS1, Line 3159: 		send_text_status(s, ustmtext("TransferCancel", s));
the corresponding localization is changed below

File codecs/lpc10/README:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/b46ab987_fafbe13a 
PS1, Line 71: The f2c output originally had a file called control_com.c, that defined
I should drop these changes

File codecs/lpc10/analys.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/4196a735_1d9d78b8 
PS1, Line 37: /* comlen control_ 12 */
Happy to drop if this is annoying

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/659791a8_ffb11c51 
PS1, Line 134: /* that was defined in the COMMON block CONTRL in control.fh. */
I can't find `contrl.fh` ... This change is probably wrong, but??

File codecs/lpc10/dyptrk.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/6059caf9_dc1d949c 
PS1, Line 318: /* SEESAW: Construct a pitch pointer array and intermediate winner function
This isn't a `control` :-)

File codecs/lpc10/voicin.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/a0a84574_b32d4a9d 
PS1, Line 545: /*  The VOICE array contains the result of the linear discriminant function
not `control`

File configs/samples/res_config_sqlite3.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/f9a324dd_dc0b3298 
PS1, Line 32: ; busy timeout - timeout in milliseconds to stop waiting for locked database.
This might be an upstream file (I have sent changes to sqlite, they weren't integrated into trunk)

File contrib/scripts/install_prereq:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/b0a7bc7a_c876e371 
PS1, Line 7: # prerequisites
notable word change

File contrib/scripts/managerproxy.pl:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/651212a6_8bfc8a55 
PS1, Line 212:     my $command = shift;
?

File funcs/func_odbc.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/2597b8a5_b06548a8 
PS1, Line 64: 					<value name="SUCCESS">
notable

File include/asterisk/bridge.h:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/7c4bce45_608948e1 
PS1, Line 1044: void ast_bridge_set_remb_behavior(struct ast_bridge *bridge, enum ast_bridge_video_sfu_remb_behavior behavior);
api change

File include/asterisk/causes.h:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/68950b7e_7e4c402e 
PS1, Line 100: #define AST_CAUSE_MISDIALED_TRUNK_PREFIX         5
api?

File main/channel.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/58f263e0_7af1d03b 
PS1, Line 139: 	{ AST_CAUSE_PREEMPTED, "PREEMPTED", "Preempted" },
hope this is ok, easily dropped if not

File main/pbx.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/f6159a3d_df9f9aeb 
PS1, Line 3947: 	/* Cleanup the NOTIFYs if hint is removed */
This is mostly to make my tool happy, certainly droppable.

Can't tell if `NOTIFY` is a technical thing, or if this could be written as `notifications`

File missing:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/b36a9ee8_946acac8 
PS1, Line 191:          it often tells you about the needed prerequisites for installing
Notable change

File res/res_corosync.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/552333e7_7d808ec7 
PS1, Line 753: 			ast_log(LOG_WARNING, "Failed to extract Corosync node ID for this node. Not informing cluster of existence.\n");
not `cacheable` (and following)

File res/res_pjsip_publish_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/945c2ca0_7e5ee0d3 
PS1, Line 497: 	int cacheable = ast_json_integer_get(ast_json_object_get(json, "cacheable"));
this would be some sort of api change, and so either needs a compat thing or to just be dropped.

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/a45ef05c_d3005eb9 
PS1, Line 518: 		cacheable == AST_DEVSTATE_CACHABLE ? AST_DEVSTATE_CACHABLE : AST_DEVSTATE_NOT_CACHABLE,
I can't remember why I didn't change the uppercase flavor.

File res/res_xmpp.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/85331f35_fbcc41dc 
PS1, Line 1663:  * \brief Dial plan function to retrieve the status of a buddy.
not `cacheable` and following

File rest-api/api-docs/endpoints.json:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/dba12bc6_0f0b098e 
PS1, Line 58: 							"description": "The \"variables\" key in the body object holds technology specific key/value pairs to append to the message. These can be interpreted and used by the various resource types; for example, pjsip and sip resource types will add the key/value pairs as SIP headers,",
?

File static-http/ajamdemo.html:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/8ab4c904_04748b63 
PS1, Line 30: 	var transferredchan = "";
?

File tests/test_utils.c:

https://gerrit.asterisk.org/c/asterisk/+/17502/comment/607e0600_5a751cbf 
PS1, Line 51: 	const char *in = "abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ 1234567890 ~`!@#$%^&*()_-+={[}]|\\:;\"'<,>.?/";
notable

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17502
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic6b76bfe3fd3f92983c5af911e91081a3a3cfa3d
Gerrit-Change-Number: 17502
Gerrit-PatchSet: 1
Gerrit-Owner: Josh Soref <jsoref at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Wed, 17 Nov 2021 05:41:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211116/618614df/attachment-0001.html>