[Asterisk-code-review] Enhance FreeBSD compilation support (asterisk[master])

[Guido Falsi]

Attention is currently required from: Sean Bright, N A.
Guido Falsi has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17362 )

Change subject: Enhance FreeBSD compilation support
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> The commit message and the JIRA issue seem to suggest that these changes are fixing compilation prob […]
Regarding the main/http.c patch, it looks like it is actually obsolete.

Looking at the FreeBSD ports commit history I could not find any definitive information, but it was added in the timeframe when FreeBSD project moved to clang.

Early clang had issues with the RAII_VAR construct.

Modern clang has no such issues. So that patch can most probably be dropped. I'm testing to remove it from FreeBSD ports tree.

The channels/chan_dahdi.c is a different thing, I think. I have never used dahdi hardware, but I suspect the FreeBSD dahdi driver is slightly different from the linux one. Maybe the one we have in the tree is also slightly older, and requires different interfacing. But I'm not sure right now about this. I need to do some studying.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17362
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ice4f615a9ea4662dd6d83594f0c9989e1b5251c0
Gerrit-Change-Number: 17362
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Guido Falsi <madpilot at freebsd.org>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 16 Nov 2021 19:41:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211116/740d9b8f/attachment.html>