[Asterisk-code-review] app_voicemail: Refactor email generation functions (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16665 )

Change subject: app_voicemail: Refactor email generation functions
......................................................................


Patch Set 2:

(1 comment)

File main/utils.c:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/6b6dfdef_20bfe209 
PS2, Line 639: int ast_file_base_encode(char *filename, FILE *so)
> Can we not leverage the existing ast_base64_encode code instead of just copying the existing code fr […]
Perhaps, but I wasn't too sure about it. ast_base64_encode uses a string input, not a file input. Is it really desirable to load an entire attachment into a string all at once, just so we can use the existing function? What if the attachment is 20, 30, 50 MB? It looked to me like the voicemail base function uses constant space.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16665
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee
Gerrit-Change-Number: 16665
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 01 Nov 2021 18:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211101/ffd36075/attachment-0001.html>