[Asterisk-code-review] app_dial: Expanded A option to add caller announcement (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15926 )

Change subject: app_dial: Expanded A option to add caller announcement
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15926/3/apps/app_dial.c 
File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15926/3/apps/app_dial.c@2965 
PS3, Line 2965: 				int ms, ms2;
These should be renamed to be clearer about which is for what


https://gerrit.asterisk.org/c/asterisk/+/15926/3/apps/app_dial.c@2993 
PS3, Line 2993: 				active_chan = ast_waitfor_n(chans, 2, &ms);
ms2 isn't actually used for scheduling or anything, it should be (that is: if ms2 is wanting things to potentially return sooner, it won't at the moment and the ast_sched_runq will be late for execution)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15926
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If6eed3ff5c341dc8c588c8210987f2571e891e5e
Gerrit-Change-Number: 15926
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 26 May 2021 16:18:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210526/99cfb1c0/attachment.html>