[Asterisk-code-review] app_confbridge: New ConfKick() application (asterisk[16])

George Joseph asteriskteam at digium.com
Mon May 24 08:22:28 CDT 2021


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15930 )

Change subject: app_confbridge: New ConfKick() application
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/15930/1/apps/app_confbridge.c 
File apps/app_confbridge.c:

https://gerrit.asterisk.org/c/asterisk/+/15930/1/apps/app_confbridge.c@161 
PS1, Line 161: 			<ref type="application">ConfKick</ref>
Probably don't want to reference ConfKick from ConfKick.  Not sure why ConfBridge references itself.


https://gerrit.asterisk.org/c/asterisk/+/15930/1/apps/app_confbridge.c@4262 
PS1, Line 4262: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/15930/1/apps/app_confbridge.c@4276 
PS1, Line 4276: 	
Whitespace



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15930
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5d96b683880bfdd27b2ab1c3f2e897c5046ded9b
Gerrit-Change-Number: 15930
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 24 May 2021 13:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210524/65bd7266/attachment.html>


More information about the asterisk-code-review mailing list