[Asterisk-code-review] res_pjsip_outbound_authenticator_digest: Be tolerant of RFC8760 UASs (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15764 )

Change subject: res_pjsip_outbound_authenticator_digest: Be tolerant of RFC8760 UASs
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c 
File res/res_pjsip_outbound_authenticator_digest.c:

https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c@220 
PS6, Line 220: 		 * about dupplicate realms until then.
a duplicate p appears!


https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c@331 
PS6, Line 331: 		 * structure contents to the array element.
I think this should be extended to state that the auth_cred structure contents may still contain pointers, which are also copied. (auth_cred.username, auth_cred.data) but they are guaranteed to remain valid.


https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c@372 
PS6, Line 372: 	creds_array = AST_VECTOR_STEAL_ELEMENTS(&auth_creds);
THIEF!


https://gerrit.asterisk.org/c/asterisk/+/15764/6/res/res_pjsip_outbound_authenticator_digest.c@461 
PS6, Line 461: 		goto cleanup;
auth_sess may be uninitialized at this point if you jump to cleanup



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15764
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3aef5ce4fe1d27e48d61268520f284d15d650281
Gerrit-Change-Number: 15764
Gerrit-PatchSet: 6
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 17 May 2021 13:48:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210517/c3de6846/attachment.html>