[Asterisk-code-review] menuselect: exit non-zero in case of failure on --enable|disable opti... (asterisk[master])

[Jaco Kroon]

Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15628 )

Change subject: menuselect: exit non-zero in case of failure on --enable|disable options.
......................................................................


Patch Set 1:

238 app_voicemail.c
 239 ------------------
 240  * The "Voicemail Build Options" section of menuselect has been removed along with
 241    the FILE_STORAGE, ODBC_STORAGE and IMAP_STORAGE menuselect options.  All 3 variants
 242    of the voicemail app can now be built at the same by enabling app_voicemail,
 243    app_voicemail_imap, and app_voicemail_odbc under the "Applications" section.
 244    By default, only app_voicemail is enabled.  Also, the modules.conf sample has
 245    been updated to "noload" app_voicemail_imap and app_voicemail_odbc should they
 246    all be built.  Packagers must update their build scripts appropriately.

Build failure here due to --enable FILE_STORAGE.  This also clarify why exactly I want this patch for packaging purposes, if our build scripts depend/want an option that is no longer present, we should take specific action to deal with it before it gets to users and cause a problem.

The above also shows that I should update our packaging accordingly for asterisk 18, so this has already picked up a build issue on our end.  I'm fairly certain it'll kick out a few more.  This does not replace the need for packagers (myself included) to properly read the UPGRADES notes, however, it does serve as a safety net in case we miss something.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15628
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I77e3466435f5a51a57538b29addb68d811af238d
Gerrit-Change-Number: 15628
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Sat, 13 Mar 2021 11:26:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210313/21ee712d/attachment.html>