[Asterisk-code-review] func_callerid+res_agi: Fix compile errors related to -Werror=zero-len... (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15496 )

Change subject: func_callerid+res_agi: Fix compile errors related to -Werror=zero-length-bounds
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> Despite the size difference, I think I prefer this approach over the other one. I do think that the comment in app.h should be extended though to state that argv should not be directly accessed.

I don't really have a strong opinion either way, although I think I lean slightly toward the other approach only because it wouldn't matter if argv is directly accessed.

I do agree though that if this approach is the only one chosen then a comment as mentioned should be added.

Since there are two patch already implemented is there any reason to not commit both?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15496
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I75152cece8a00b7523d542e5ac22796f9595692b
Gerrit-Change-Number: 15496
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 03 Mar 2021 17:54:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210303/89bd5958/attachment.html>