[Asterisk-code-review] app_sendmf: New SendMF application (asterisk[master])

[Sarah Autumn]

Attention is currently required from: N A.
Sarah Autumn has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16080 )

Change subject: app_sendmf: New SendMF application
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1: 
This is a good idea. The only reservations I have are the notes left at line 95, but that's less of a concern regarding your choices, and more of a concern about the way things are named in sig_analog.c


File apps/app_sendmf.c:

https://gerrit.asterisk.org/c/asterisk/+/16080/comment/fae82626_51a4fccc 
PS1, Line 95: 		"1100+1700", /* K (KP) */
This differs from the characters used for KP, ST, etc in sig_analog.c (for example, line 1860). To be honest, I think your usage is better, but I just wanted to point out the discrepancy, and that it should probably be addressed.

In sig_analog, the following conventions are used:
KP = *
ST = #
STP = A
ST2P = B
ST3P = C

I don't think that the usage in sig_analog is exposed to the user, so this could be good opportunity to refactor that to match your new notation, and have consistent representations going forward.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16080
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5d89afdbccee3f86cc702ed96d882f3d351327a4
Gerrit-Change-Number: 16080
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 29 Jun 2021 21:55:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210629/92f0fc99/attachment.html>