[Asterisk-code-review] func_frame_drop: New function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16071 )

Change subject: func_frame_drop: New function
......................................................................


Patch Set 5:

(4 comments)

File funcs/func_frame_drop.c:

https://gerrit.asterisk.org/c/asterisk/+/16071/comment/e6836e13_58309476 
PS4, Line 45: filter list type
> You still should change this to "direction".
Ack


https://gerrit.asterisk.org/c/asterisk/+/16071/comment/264fbffc_db86cd99 
PS4, Line 276: strcasecmp
> Per my other comment, you can't use strcasecmp because "value" could have multiple frame types in it […]
Ack


File funcs/func_framedrop.c:

https://gerrit.asterisk.org/c/asterisk/+/16071/comment/cfab9e56_210dcb8d 
PS2, Line 195: int list_type; /* 0 = TX, 1 = RX */
> Sorry.  I meant create an enum for the list_type... […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/16071/comment/bef780c0_d99cc116 
PS2, Line 278: 	for (i = 0; i < ARRAY_LEN(frametype2str); i++) {
             : 		if (strcasestr(value, frametype2str[i].str)) {
             : 			framedata->values[i] = 1;
             : 		}
             : 	}
             : 
             : 	for (i = 0; i < ARRAY_LEN(controlframetype2str); i++) {
             : 		if (strcasestr(value, controlframetype2str[i].str)) {
             : 			framedata->controlvalues[i] = 1;
             : 		}
             : 	}
> > Whoops, didn't notice that before. What about strcasecmp instead of strcasestr? […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16071
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8147c9d55d74e2e48861edba6b22f930920541ec
Gerrit-Change-Number: 16071
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 14:05:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210622/470a8159/attachment-0001.html>