[Asterisk-code-review] res_pjsip_sdp_rtp: Evaluate remotely held for Session Progress (asterisk[18])

[Bernd Zobl]

Attention is currently required from: Bernd Zobl.
Hello Friendly Automation, Richard Mudgett, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/16108

to look at the new patch set (#2).

Change subject: res_pjsip_sdp_rtp: Evaluate remotely held for Session Progress
......................................................................

res_pjsip_sdp_rtp: Evaluate remotely held for Session Progress

With the fix for ASTERISK_28754 channels are no longer put on hold if an
outbound INVITE is answered with a "Session Progress" containing
"inactive" audio.

The previous change moved the evaluation of the media attributes to
`negotiate_incoming_sdp_stream()` to have the `remotely_held` status
available when building the SDP in `create_outgoing_sdp_stream()`.
This however means that an answer to an outbound INVITE, which does not
traverse `negotiate_incoming_sdp_stream()`, cannot set the
`remotely_held` status anymore.

This change moves the check so that both, `negotiate_incoming_sdp_stream()` and
`apply_negotiated_sdp_stream()` can do the checks.

ASTERISK-29479

Change-Id: Icde805a819399d5123b688e1ed1d2bcd9d5b0f75
---
M res/res_pjsip_sdp_rtp.c
1 file changed, 27 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/08/16108/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16108
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Icde805a819399d5123b688e1ed1d2bcd9d5b0f75
Gerrit-Change-Number: 16108
Gerrit-PatchSet: 2
Gerrit-Owner: Bernd Zobl <b.zobl at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Bernd Zobl <b.zobl at commend.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210617/4dc4fb2b/attachment-0001.html>