[Asterisk-code-review] app_waitforcond: New application (asterisk[16])

[N A]

Attention is currently required from: Joshua Colp, Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15928 )

Change subject: app_waitforcond: New application
......................................................................


Patch Set 7:

(2 comments)

File apps/app_waitforcond.c:

https://gerrit.asterisk.org/c/asterisk/+/15928/comment/620e30d1_3f6db22b 
PS7, Line 210: 		pbx_substitute_variables_helper(chan, expr, condition, sizeof(condition) - 1);
> Looking at pbx_substitute_variables_helper I don't think you need the "expr = ast_strdupa(expression […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/15928/comment/c0b5cad7_4bbe85d5 
PS7, Line 237: AST_MODULE_INFO_STANDARD(ASTERISK_GPL_KEY, "Wait until condition is true");
> This needs to use AST_MODULE_INFO_STANDARD_EXTENDED to be marked as extended support.
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15928
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I08adf2824b8bc63405778cf355963b5005612f41
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 15 Jun 2021 12:57:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210615/bc28769e/attachment-0001.html>