[Asterisk-code-review] app_confbridge: New option to prevent answer supervision (asterisk[16])

[George Joseph]

Attention is currently required from: N A, Richard Mudgett.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15918 )

Change subject: app_confbridge: New option to prevent answer supervision
......................................................................


Patch Set 4: Code-Review+2

(3 comments)

File apps/app_confbridge.c:

https://gerrit.asterisk.org/c/asterisk/+/15918/comment/d8e86878_db97b424 
PS2, Line 2588: !
> I think you forgot to remote the '!' 😊
Done


File apps/confbridge/conf_config_parser.c:

https://gerrit.asterisk.org/c/asterisk/+/15918/comment/2aa8fb2d_53c89e84 
PS1, Line 2419: 	/* Negative logic. Defaults to "yes" and evaluates with ast_false(). If !ast_false(), USER_OPT_NOANSWER is cleared */
              : 	aco_option_register(&cfg_info, "answer_channel", ACO_EXACT, user_types, "yes", OPT_BOOLFLAG_T, 0, FLDSET(struct user_profile, flags), USER_OPT_NOANSWER);
> The negative logic is a bit confusing.  I'd stick to  […]
Done


File apps/confbridge/conf_config_parser.c:

https://gerrit.asterisk.org/c/asterisk/+/15918/comment/6f4874eb_0d2b416f 
PS2, Line 2419: 	/* Negative logic. Defaults to "yes" and evaluates with ast_false(). If !ast_false(), USER_OPT_ANSWER_CHANNEL is cleared */
> You can get rid of the comment now.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15918
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I26642729d0345f178c7b8045506605c8402de54b
Gerrit-Change-Number: 15918
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 08 Jun 2021 18:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210608/341c22f2/attachment.html>