[Asterisk-code-review] app_reload: New Reload application (asterisk[16])

[N A]

Attention is currently required from: Joshua Colp, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15962 )

Change subject: app_reload: New Reload application
......................................................................


Patch Set 3:

(1 comment)

File apps/app_reload.c:

https://gerrit.asterisk.org/c/asterisk/+/15962/comment/8e924a6f_ac06c48e 
PS3, Line 88: 	if (!ast_strlen_zero(target)) {
> Aliases don't exist in the core, so no, there is no unaliasing.
Would it be reasonable to add it to the core as something more generic? But that might be a much larger undertaking, bugger than the scope of what's intended here.

Most things aren't too difficult to specify the full name of, the common problem I anticipate without aliases is most people will likely not know that Reload(pbx_config) is how the dialplan gets reloaded, but I could build this into the documentation via several examples, which might alleviate this issue - would that be a better way?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15962
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic8ab025d8b38dd525b872b41c465c999c5810774
Gerrit-Change-Number: 15962
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 08 Jun 2021 14:52:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210608/44db1f4f/attachment.html>