[Asterisk-code-review] res_stasis_playback (asterisk[master])

[Joshua Colp]

Attention is currently required from: Andre Barbosa.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15987 )

Change subject: res_stasis_playback
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15987/comment/4e0aa56e_0f513e70 
PS1, Line 7: res_stasis_playback
This needs to follow the commit message formatting[1]

[1] https://wiki.asterisk.org/wiki/display/AST/Commit+Messages#CommitMessages-BasicFormatforCommitMessages


Patchset:

PS1: 
The rest-api/api-docs/recordings.json file needs to be updated with this new state. That being said - there is already a failed state, what is the difference between error and failed?


File res/res_stasis_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/15987/comment/df48a147_897e1706 
PS1, Line 111: 		type = "PlaybackFinished";		
Redness


https://gerrit.asterisk.org/c/asterisk/+/15987/comment/240fa444_5739dfad 
PS1, Line 208: 		return "error";		
Redness



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15987
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4c2e5921cc597702513af0d7c6c2c982e1798322
Gerrit-Change-Number: 15987
Gerrit-PatchSet: 1
Gerrit-Owner: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Comment-Date: Tue, 08 Jun 2021 14:18:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210608/f1fc6f37/attachment.html>