[Asterisk-code-review] sip_to_pjsip: Fix missing cases (asterisk[16])

Sean Bright asteriskteam at digium.com
Thu Jun 3 14:20:19 CDT 2021


Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16010 )

Change subject: sip_to_pjsip: Fix missing cases
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

Patchset:

PS2: 
What about the transport problem:

 > My TLS method from tlsv1 to sslv23, exactly the protocols I was prohibiting. Seems backwards.


File contrib/scripts/sip_to_pjsip/sip_to_pjsip.py:

https://gerrit.asterisk.org/c/asterisk/+/16010/comment/c7a886ce_e269c778 
PS2, Line 161:     if val == 'inband' or val == 'info':
Just tack this on to the end:

 or val == 'auto':


https://gerrit.asterisk.org/c/asterisk/+/16010/comment/28430a3c_5022fce5 
PS2, Line 165:     elif val == 'auto':
             :         set_value(key, 'auto', section, pjsip, nmapped)
Delete this



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16010
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie27d6606efad3591038000e5f3c34fa94730f6f2
Gerrit-Change-Number: 16010
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 03 Jun 2021 19:20:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210603/a846d3cb/attachment.html>


More information about the asterisk-code-review mailing list