[Asterisk-code-review] func_sayfiles: Retrieve say file names (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16226 )

Change subject: func_sayfiles: Retrieve say file names
......................................................................


Patch Set 2:

(1 comment)

File include/asterisk/say.h:

https://gerrit.asterisk.org/c/asterisk/+/16226/comment/10ce6a46_60be7280 
PS2, Line 191: struct ast_str* ast_get_character_str_full(const char *str, const char *lang, enum ast_say_case_sensitivity sensitivity);
> Are you sure about this? func_sayfiles no longer compiles if I move it into the C++. […]
Yes, it's done in case someone wants to use it from inside of a C++ module. Having it outside will cause that to fail for that case. They should still end up being declared in a C module the same (the #if defined won't trigger for C modules resulting in the header file being the same as if they were outside), and this pattern is used throughout the tree with success.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16226
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If9718c89353b8e153d84add3cc4637b79585db19
Gerrit-Change-Number: 16226
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 29 Jul 2021 21:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210729/e57cbf8c/attachment-0001.html>