[Asterisk-code-review] app_dtmfstore: New application to store digits (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16070 )

Change subject: app_dtmfstore: New application to store digits
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Patchset:

PS3: 
So for some reason, only the last digit received is getting stored now because each callback invocation, it's unable to retrieve the variable from the previous round.
This *used* to work correctly and comparing this with an earlier version, I see nothing obvious that stands out. Adding the ast_strdupa back in did not help. The problem is pbx_builtin_getvar_helper(chan, varname) is always NULL in the callback, even though reading the variable in the dialplan returns a value.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16070
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I51aa93fc9507f7636ac44806c4420ce690423e6f
Gerrit-Change-Number: 16070
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 05 Jul 2021 22:23:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210705/1f7d520d/attachment.html>