[Asterisk-code-review] app_stack: Adds conditional return application (asterisk[master])

[Corey Farrell]

Attention is currently required from: N A.
Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16077 )

Change subject: app_stack: Adds conditional return application
......................................................................


Patch Set 2: Code-Review-2

(1 comment)

Patchset:

PS2: 
We already have ExecIf which can be used to return only if a condition is true, alternatively you could use GotoIf to skip a return or jump to a return.  For cases where you want to return different values for true/false condition you should use the dialplan function IF.

This is not a review of any code, the -2 because we don't need alternative ways for dialplan to do things that dialplan can already do.  Being able to write a single line of dialplan in a different way (even if slightly simpler) is not enough to get past the objection to bloat.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16077
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I046b778bd98a2aa97bd58b058ee77f7504407425
Gerrit-Change-Number: 16077
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 01 Jul 2021 10:28:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210701/d93181b4/attachment.html>