[Asterisk-code-review] res/res_pjsip.c: allow user=phone when number contain *# (asterisk[18])

Mark Petersen asteriskteam at digium.com
Fri Jan 22 07:37:40 CST 2021


Mark Petersen has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/15336 )


Change subject: res/res_pjsip.c: allow user=phone when number contain *#
......................................................................

res/res_pjsip.c: allow user=phone when number contain *#

if From number contain * or # asterisk will not add user=phone

Currently only number that uses AST_DIGIT_ANYNUM can have "user=phone" but the validation should use AST_DIGIT_ANY
this is a problem when you want to send call to ISUP
as they will disregard the From header and either replace From with anonymous or with p-asserted-identity

ASTERISK-29261
Reported by: Mark Petersen
Tested by: Mark Petersen

Change-Id: I3307bdbf757582740bfee4110e85f7b6c9291cc4
---
M res/res_pjsip.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/36/15336/1

diff --git a/res/res_pjsip.c b/res/res_pjsip.c
index f99135a..1b44aa6 100644
--- a/res/res_pjsip.c
+++ b/res/res_pjsip.c
@@ -3898,7 +3898,7 @@
 
 	/* Test URI user against allowed characters in AST_DIGIT_ANY */
 	for (; i < pj_strlen(&sip_uri->user); i++) {
-		if (!strchr(AST_DIGIT_ANYNUM, pj_strbuf(&sip_uri->user)[i])) {
+		if (!strchr(AST_DIGIT_ANY, pj_strbuf(&sip_uri->user)[i])) {
 			break;
 		}
 	}

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15336
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I3307bdbf757582740bfee4110e85f7b6c9291cc4
Gerrit-Change-Number: 15336
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210122/d71525d4/attachment.html>


More information about the asterisk-code-review mailing list