[Asterisk-code-review] pjsip_scheduler: Fix pjsip show scheduled_tasks like for compiler Clang. (asterisk[16])

Joshua Colp asteriskteam at digium.com
Mon Jan 18 10:37:13 CST 2021


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/15354 )

Change subject: pjsip_scheduler: Fix pjsip show scheduled_tasks like for compiler Clang.
......................................................................

pjsip_scheduler: Fix pjsip show scheduled_tasks like for compiler Clang.

Otherwise, Clang 10 warned because of logical-not-parentheses.

Change-Id: Ia8fb493f727b08070eb2dcf520c08df34ed11d79
---
M res/res_pjsip/pjsip_scheduler.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  Sean Bright: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved



diff --git a/res/res_pjsip/pjsip_scheduler.c b/res/res_pjsip/pjsip_scheduler.c
index ac53379..0b7adc1 100644
--- a/res/res_pjsip/pjsip_scheduler.c
+++ b/res/res_pjsip/pjsip_scheduler.c
@@ -517,7 +517,7 @@
 
 	if (a->argc == 5) {
 		int regrc;
-		if (!strcasecmp(a->argv[3], "like") == 0) {
+		if (strcasecmp(a->argv[3], "like")) {
 			return CLI_SHOWUSAGE;
 		}
 		regrc = regcomp(&regex, a->argv[4], REG_EXTENDED | REG_ICASE | REG_NOSUB);

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15354
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia8fb493f727b08070eb2dcf520c08df34ed11d79
Gerrit-Change-Number: 15354
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210118/49ba6451/attachment-0001.html>


More information about the asterisk-code-review mailing list