[Asterisk-code-review] Stasis/messaging: tech subscriptions conflict with endpoint subscript... (asterisk[master])

[Joshua Colp]

Attention is currently required from: Jean Aunis - Prescom.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15301 )

Change subject: Stasis/messaging: tech subscriptions conflict with endpoint subscriptions.
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS2: 
I think the testsuite[1] should also have a test added to cover this scenario.

[1] https://github.com/asterisk/testsuite/tree/master/tests/rest_api/message


File res/stasis/messaging.c:

https://gerrit.asterisk.org/c/asterisk/+/15301/comment/811c633c_088be48a 
PS2, Line 325: 	ast_rwlock_rdlock(&tech_subscriptions_lock);
I think some comments in the code detailing what each block of code is responsible for would be good for someone reading it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15301
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I9eac4cba5f9e27285a282509395347abc58fc2b8
Gerrit-Change-Number: 15301
Gerrit-PatchSet: 2
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Comment-Date: Tue, 05 Jan 2021 11:33:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210105/1e024a8b/attachment-0001.html>