[Asterisk-code-review] app.h: Restore C++ compatibility for macro AST_DECLARE_APP_ARGS (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15441 )

Change subject: app.h: Restore C++ compatibility for macro AST_DECLARE_APP_ARGS
......................................................................


Patch Set 3:

res_agi as well,

res_agi.c: In function ‘agi_exec_full’:
res_agi.c:4513:11: error: array subscript ‘<unknown>’ is outside the bounds of an interior zero-length array ‘char *[0]’ [-Werror=zero-length-bounds]
 4513 |  args.argv[args.argc] = NULL;
      |  ~~~~~~~~~^~~~~~~~~~~
res_agi.c:4499:36: note: while referencing ‘argv’
 4499 |  AST_DECLARE_APP_ARGS(args,
      |                                    ^   
res_agi.c:4499:64: note: defined here ‘args’
 4499 |  AST_DECLARE_APP_ARGS(args,
      |                                                                ^   
res_agi.c:4521:8: error: array subscript 0 is outside the bounds of an interior zero-length array ‘char *[0]’ [-Werror=zero-length-bounds]
 4521 |  res = launch_script(chan, args.argv[0], args.argc, args.argv, fds, enhanced ? &efd : NULL, &pid);

But after disabling those two I can build.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15441
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5b9f02a9b290675682a1d13f1788fdda597c9fca
Gerrit-Change-Number: 15441
Gerrit-PatchSet: 3
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 24 Feb 2021 12:55:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210224/bf98f069/attachment.html>