[Asterisk-code-review] res_pjsip_refer: Refactor progress locking and serialization (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15494 )

Change subject: res_pjsip_refer: Refactor progress locking and serialization
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15494/1/res/res_pjsip_refer.c 
File res/res_pjsip_refer.c:

https://gerrit.asterisk.org/c/asterisk/+/15494/1/res/res_pjsip_refer.c@141 
PS1, Line 141: 	/* Send a deferred initial 100 Trying SIP frag NOTIFY if we haven't already. */
> I think we have to move the unlock to before this comment. […]
It has to be held for the duration, or another thread can cause the underlying evsub to be partially destroyed. Sending a NOTIFY on such an evsub would drift into undefined territory.


https://gerrit.asterisk.org/c/asterisk/+/15494/1/res/res_pjsip_refer.c@313 
PS1, Line 313: 		progress->sub = NULL;
Add a comment explaining the locking and protection here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15494
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I97a8bb01771a3c85345649b8124507f7622a8480
Gerrit-Change-Number: 15494
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 24 Feb 2021 10:58:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210224/c44c2d69/attachment.html>