[Asterisk-code-review] res_pjsip_session.c: Check topology on re-invite. (asterisk[16])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15445 )

Change subject: res_pjsip_session.c: Check topology on re-invite.
......................................................................


Patch Set 1:

(1 comment)

> Patch Set 1:
> 
> Do you mean that it is related with issue - ASTERISK-29215?

This appears to be a different issue. active_media_state and session->active_media_state can have different values. For that particular issue you mentioned, active_media_state is not NULL, but its topology is, which is causing the crash.

https://gerrit.asterisk.org/c/asterisk/+/15445/1/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/15445/1/res/res_pjsip_session.c@2449 
PS1, Line 2449: 				if ((topology_change_request || session->active_media_state) && ast_stream_topology_equal(session->active_media_state->topology, pending_media_state->topology)) {
> > I _think_ this will suppress connected line updates since in that case there will be an active med […]
As far as connected line updates go, I ran an attended_transfer testsuite test with and without this patch - both runs had connected line updates, so it should be ok.

As for the session->active_media_state, there's actually another area further up in the pending_media_state conditional that checks the topology as well. I'm not sure what scenarios would cause it to be NULL when it gets to this point, but could add a NULL check to both just to be safe?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15445
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I04dc91befb2387904e28a9aaeaa3bcdbcaa7fa63
Gerrit-Change-Number: 15445
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Wed, 17 Feb 2021 19:56:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210217/755dd467/attachment.html>