[Asterisk-code-review] res_format_attr_h263: Generate valid SDP fmtp for H.263+. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15401 )

Change subject: res_format_attr_h263: Generate valid SDP fmtp for H.263+.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> The problem is that fixing the Test Suite is going to fail the Asterisk project until my Asterisk project change is included. I cannot make the Test Suite compatible without making big changes to that test cases.
> 
> Are you OK with such a tentative situation, I fix the test suite and it fails until this here is merged? Or a perhaps better alternative: I remove those two cases all together because one case, the one for H.264 is more than enough?

If the Asterisk change requires a testsuite change, then it's fine if a failure occurs as long as it is stated on the Asterisk review that the testsuite change also exists.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15401
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I95a650c715007b8dde11a77cb37d9c6c123a441e
Gerrit-Change-Number: 15401
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 17 Feb 2021 13:19:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210217/84e963f5/attachment.html>