[Asterisk-code-review] res_format_attr_h263: Generate valid SDP fmtp for H.263+. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15401 )

Change subject: res_format_attr_h263: Generate valid SDP fmtp for H.263+.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > There are legitimate test failures with this change.
> 
> Can you elaborate a bit on this legitimation? To be honest, I have no clue, why four areas fail. So far, I only understand two: When I look at <https://github.com/asterisk/testsuite/blob/master/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_A_h263.xml> and <https://github.com/asterisk/testsuite/blob/master/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_A_h263_13.xml> the Regular Expression is wrong. It not only expects a certain order (which changed) but also still expects ‘VGA=0’ (which is wrong). How Do I tackle this: Am I able to submit one change which applies to both projects (asterisk and testsuite)? Or are you correcting that particular H.263 scenarios for SIPp?

Testsuite is a separate project and requires a separate review. Generally the individual making the change is the one who also updates or fixes any testsuite tests that need changing as a result, or adds new tests. If this is not possible then it can be stated as such and another person can investigate resolving it when they can.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15401
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I95a650c715007b8dde11a77cb37d9c6c123a441e
Gerrit-Change-Number: 15401
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 17 Feb 2021 10:10:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210217/0603e4c2/attachment.html>