[Asterisk-code-review] tcptls.c: refactor client connection to be more robust (asterisk[16])

[Sean Bright]

Attention is currently required from: Kevin Harwell.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17720 )

Change subject: tcptls.c: refactor client connection to be more robust
......................................................................


Patch Set 2:

(2 comments)

File main/tcptls.c:

https://gerrit.asterisk.org/c/asterisk/+/17720/comment/86b82f3c_5d65992d 
PS2, Line 663: 	ast_fd_clear_flags(desc->accept_fd, O_NONBLOCK);
> Potentially dumb question, but: Why are we clearing O_NONBLOCK here but...
I didn't read the commit message - disregard.


https://gerrit.asterisk.org/c/asterisk/+/17720/comment/632a2bb5_0df460c2 
PS2, Line 692: 	fd = desc->accept_fd = ast_socket_nonblock(ast_sockaddr_is_ipv6(&desc->remote_address) ?
> ... […]
I didn't read the commit message - disregard.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17720
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I907571843a83e43c0742b95a64785f4411f02671
Gerrit-Change-Number: 17720
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 28 Dec 2021 21:46:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211228/537ab859/attachment.html>