[Asterisk-code-review] app_sf: Add full tech-agnostic SF support (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17652 )

Change subject: app_sf: Add full tech-agnostic SF support
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/17652/comment/1d8f55b4_130ab0b9 
PS3, Line 877: 	freq = ast_alloca(SF_BUF_LEN); /* freed at the end */
I'd remove the comment here ('freed ...'). The memory is automatically released on stack pop now so while the comment is technically correct most might think the comment implies a heap release.


https://gerrit.asterisk.org/c/asterisk/+/17652/comment/c55fa81c_8a287a31 
PS3, Line 966: 	ast_free(freq);
Now that you are allocating on the stack this can be removed. Surprised it didn't crash.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17652
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7ec50752e9a661af639425e5d1e339f17411bcad
Gerrit-Change-Number: 17652
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 16 Dec 2021 15:46:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211216/48c2ca39/attachment.html>