[Asterisk-code-review] cdr: allow disabling CDR by default on new channels (asterisk[master])

[N A]

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17701 )

Change subject: cdr: allow disabling CDR by default on new channels
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
The tests are failing because test_cdr.c doesn't respect the defaults in cdr.c. Instead, it directly sets the flags to use by or'ing bits: https://github.com/asterisk/asterisk/blob/b4347c486150653ec7ce1d129e8f9017c69344da/tests/test_cdr.c#L60

This is failing because a flag was added which defaults to 1.

There are two ways to proceed here:
1) Simply add | CDR_DEFAULT_ENABLED to each of the debug_cdr_config flags in test_cdr.c
2) Make CDR_DEFAULT_ENABLED default to 0 instead of 1. Then, since test_cdr doesn't know about it, it won't set that and so we end up with the correct default of 0, simply by doing nothing.

What would be preferred - thoughts, anyone?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17701
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibb78c11974bda229bbb7004b64761980e0b2c6d1
Gerrit-Change-Number: 17701
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Wed, 15 Dec 2021 22:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211215/f6a131cd/attachment.html>