[Asterisk-code-review] app_queue.c: added DIALEDPEERNUMBER on outgoing channel (asterisk[16])

[Joshua Colp]

Attention is currently required from: Mark Petersen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17598 )

Change subject: app_queue.c: added DIALEDPEERNUMBER on outgoing channel
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/17598/comment/9855eb05_d126ccff 
PS4, Line 4653: 	pbx_builtin_setvar_helper(tmp->chan, "DIALEDPEERNUMBER", strlen(tech) ? 1 + strlen(tech) + tmp->interface : tmp->interface);
Should this use location instead if present, which already has the stripped tech?
As well a comment explaining the use of location and fallback to tmp->interface would be good too.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17598
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Icbc589ea2066f0c401a892bf478f6b2fd44e62f6
Gerrit-Change-Number: 17598
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Tue, 14 Dec 2021 10:24:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211214/ef29376a/attachment.html>