[Asterisk-code-review] strings: Fix enum names in comment examples (asterisk[18])

Joshua Colp asteriskteam at digium.com
Tue Dec 14 04:19:10 CST 2021


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/17674 )

Change subject: strings: Fix enum names in comment examples
......................................................................

strings: Fix enum names in comment examples

The enum values for ast_strsep_flags includes
AST_STRSEP_STRIP. However, some comments reference
AST_SEP_STRIP, which doesn't exist. This fixes
these comments to use the correct value.

ASTERISK-29800 #close

Change-Id: If7bbd0c0e6226a211d25ddf9d1629347e2674943
---
M include/asterisk/strings.h
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/include/asterisk/strings.h b/include/asterisk/strings.h
index 65a4289..ab46273 100644
--- a/include/asterisk/strings.h
+++ b/include/asterisk/strings.h
@@ -289,13 +289,13 @@
 	char *mystr = ast_strdupa("abc=def,ghi='zzz=yyy,456',jkl");
 	char *token, *token2, *token3;
 
-	while((token = ast_strsep(&mystr, ',', AST_SEP_STRIP))) {
+	while((token = ast_strsep(&mystr, ',', AST_STRSEP_STRIP))) {
 		// 1st token will be aaa=def
 		// 2nd token will be ghi='zzz=yyy,456'
-		while((token2 = ast_strsep(&token, '=', AST_SEP_STRIP))) {
+		while((token2 = ast_strsep(&token, '=', AST_STRSEP_STRIP))) {
 			// 1st token2 will be ghi
 			// 2nd token2 will be zzz=yyy,456
-			while((token3 = ast_strsep(&token2, ',', AST_SEP_STRIP))) {
+			while((token3 = ast_strsep(&token2, ',', AST_STRSEP_STRIP))) {
 				// 1st token3 will be zzz=yyy
 				// 2nd token3 will be 456
 				// and so on

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17674
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: If7bbd0c0e6226a211d25ddf9d1629347e2674943
Gerrit-Change-Number: 17674
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211214/4e98548b/attachment.html>


More information about the asterisk-code-review mailing list