[Asterisk-code-review] chan_iax2: Add ANI2/OLI information element (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16342 )

Change subject: chan_iax2: Add ANI2/OLI information element
......................................................................


Patch Set 1:

(1 comment)

File channels/chan_iax2.c:

https://gerrit.asterisk.org/c/asterisk/+/16342/comment/7f1006e7_5598c992 
PS1, Line 5185: 	iax_ie_append_int(&ied, IAX_IE_CALLINGANI2, ast_channel_connected(c)->ani2);
> This should probably not be sent if the IAX_SENDANI flag is not set? Or should a similar flag be add […]
I left it outside of that check because ANI2 can be sent even if there isn't any ANI (e.g. ANI failure, for example - ANI2 digit 2 is sent to indicate that there is no ANI) and ANI/Caller ID with Asterisk doesn't always seem to line up, e.g. CALLERID(num) could be set but not CALLERID(ANI-num). But, I guess that's not quite what the flag is for maybe, and I don't feel that strongly about this, either.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16342
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iaeacdf6ccde18eaff7f776a0f49fee87dcb549d2
Gerrit-Change-Number: 16342
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 18:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210824/344c7a3a/attachment.html>