[Asterisk-code-review] app_milliwatt: Timing fix (asterisk[master])

[N A]

Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16238 )

Change subject: app_milliwatt: Timing fix
......................................................................


Patch Set 3:

(2 comments)

Patchset:

PS1: 
> > The documentation for this application says that it plays a continuous 1004MHz tone. […]
Ack


Patchset:

PS3: 
> The default should be the current behavior. The optional argument would enable the 1 second pause.
Even though the default behavior is incorrect?

Nobody seriously using this application wants the existing behavior. It's not how a Milliwatt test line works (probably whoever wrote this was unfamiliar with the specification). Shouldn't the default be "correct" behavior, with an option to enable "incorrect" behavior? Why keep an invalid default when we know it's wrong?

If you call any real Milliwatt number (e.g. (503)-697-1000), they all have the 1s pause and people expect that an application called "Milliwatt" will be... an actual Milliwatt.

e.g. pg. 9 here: https://downloads.avaya.com/elmodocs2/comm_mgr/r5_1/03-603118_AnalogTestHeal_June2008.pdf

The official AT&T specification here: https://primeaccess.att.com//commonfiles/Swbt/1482/Description%20of%20Test%20Lines.doc

The existing default isn't a Milliwatt, it's just a loud PlayTones(1004).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16238
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I73ccc6c6fcaa31931c6fff3b85ad1805b2ce9d8c
Gerrit-Change-Number: 16238
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 13:52:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210813/1730104b/attachment-0001.html>