[Asterisk-code-review] func_scramble: Audio scrambler function (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell, Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16231 )

Change subject: func_scramble: Audio scrambler function
......................................................................


Patch Set 6:

(3 comments)

File funcs/func_scramble.c:

https://gerrit.asterisk.org/c/asterisk/+/16231/comment/84f5e1bb_8ebc059c 
PS5, Line 205: 	} else if (!strcasecmp(args.direction, "remove")) {
             : 		return remove_scrambler(chan);
> Check this case first prior even to the datastore find above. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16231/comment/3802fb73_111536b7 
PS5, Line 208: 		ast_log(LOG_ERROR, "Direction must be either RX, TX or remove\n");
             : 		return -1;
> datastore can be leaked here if created, but not added.
Done


https://gerrit.asterisk.org/c/asterisk/+/16231/comment/945f4cc5_b3af6141 
PS5, Line 212: 	if (is_new) {
             : 		datastore->data = ni;
             : 		ast_channel_lock(chan);
             : 		ast_channel_datastore_add(chan, datastore);
             : 		ast_channel_unlock(chan);
             : 		ast_audiohook_attach(chan, &ni->audiohook);
             : 	}
> I think it'd read easier if you moved this to right after you create the datastore above and drop th […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16231
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I01020769d91060a1f56a708eb405f87648d1a67e
Gerrit-Change-Number: 16231
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 02:45:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210809/9dfee988/attachment.html>