[Asterisk-code-review] func_evalexten: Extension evaluation function (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Sarah Autumn, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_evalexten: Extension evaluation function
......................................................................


Patch Set 10:

(2 comments)

File funcs/func_evalexten.c:

https://gerrit.asterisk.org/c/asterisk/+/16075/comment/45c907ee_49b9e78a 
PS10, Line 71: 			
> whitespace.
Ack


https://gerrit.asterisk.org/c/asterisk/+/16075/comment/e852c53c_aae8965c 
PS10, Line 171: 	ast_channel_unlock(chan);
> I think I missed this before but you should keep the lock while you do the substitute.
You did comment on this last time, I had a question about it, but I accidentally marked it as resolved, so it here it is again: Would this actually work? If an EVAL_EXTEN calls another EVAL_EXTEN, then the channel is already locked so the second one will fail. What is the downside if the channel is not locked?

In other words, I think locking for the substitution could lead to a deadlock.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 10
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 09 Aug 2021 13:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210809/c33232ae/attachment.html>