[Asterisk-code-review] app_morsecode: Add American Morse code (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16230 )

Change subject: app_morsecode: Add American Morse code
......................................................................


Patch Set 3:

(2 comments)

File apps/app_morsecode.c:

https://gerrit.asterisk.org/c/asterisk/+/16230/comment/4e773150_70acc2d9 
PS2, Line 214: 	ast_channel_unlock(chan);
> There is no need to unlock and lock here, it can just be held the entire time the dialplan variables […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16230/comment/c99d9541_6eff75f1 
PS2, Line 218: 	codetype = pbx_builtin_getvar_helper(chan, "MORSETYPE");
> If the channel lock isn't held for the entire duration while the return value of pbx_builtin_getvar_ […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16230
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I172431a2e18e6527d577e74adfb05b154cba7bd4
Gerrit-Change-Number: 16230
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:39:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210805/ef72241a/attachment.html>