[Asterisk-code-review] app_morsecode: Add American Morse code (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16230 )

Change subject: app_morsecode: Add American Morse code
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

File apps/app_morsecode.c:

https://gerrit.asterisk.org/c/asterisk/+/16230/comment/5b8ea88c_79cf6204 
PS2, Line 214: 	ast_channel_unlock(chan);
There is no need to unlock and lock here, it can just be held the entire time the dialplan variables are accessed.


https://gerrit.asterisk.org/c/asterisk/+/16230/comment/7066f0b9_cf71c0ef 
PS2, Line 218: 	codetype = pbx_builtin_getvar_helper(chan, "MORSETYPE");
If the channel lock isn't held for the entire duration while the return value of pbx_builtin_getvar_helper is used then this isn't safe. You'd need to use ast_strdupa to duplicate the value, or use an integer or something to indicate which one.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16230
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I172431a2e18e6527d577e74adfb05b154cba7bd4
Gerrit-Change-Number: 16230
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:04:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210805/896c9c98/attachment.html>