[Asterisk-code-review] app_queue: Allow streaming multiple announcement files (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16221 )

Change subject: app_queue: Allow streaming multiple announcement files
......................................................................


Patch Set 3:

(2 comments)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/16221/comment/009c912e_55146044 
PS1, Line 6963: 					while ((front = strsep(&announce, "&"))) {
> I believe announce needs to be duplicated using ast_strdupa, or else this may modify "qe->announce"  […]
Done


File doc/CHANGES-staging/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/16221/comment/9bcceb03_295e095d 
PS2, Line 1: Subject: app_queue.c
> CHANGES files must have a .txt suffix. […]
File renamed.
I'm not sure how it would be done with the test suite, but I am using it on my system though and it works properly. Should I still cherry pick or find a way to test first?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16221
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iec600d8cd5ba14aa1e4e37f906accb356cd7891a
Gerrit-Change-Number: 16221
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 03 Aug 2021 12:44:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210803/516adec4/attachment-0001.html>