[Asterisk-code-review] STIR/SHAKEN: Switch to base64 URL encoding. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15814 )

Change subject: STIR/SHAKEN: Switch to base64 URL encoding.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15814/2/include/asterisk/utils.h 
File include/asterisk/utils.h:

https://gerrit.asterisk.org/c/asterisk/+/15814/2/include/asterisk/utils.h@287 
PS2, Line 287: parametre
s/parametre/parameter or did you mean to spell it that way (guess technically it's an alternative?)


https://gerrit.asterisk.org/c/asterisk/+/15814/2/res/res_stir_shaken.c 
File res/res_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/15814/2/res/res_stir_shaken.c@1009 
PS2, Line 1009: 	uuid_str = ast_malloc(AST_UUID_STR_LEN);
Since you know the exact length and it will always be the same just use a stack variable for this instead.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15814
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Icf094a2a54e87db91d6b12244c9f5ba4fc2e0b8c
Gerrit-Change-Number: 15814
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 22:50:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210429/bca6ece3/attachment.html>