[Asterisk-code-review] res_musiconhold: Clarify that playlist mode only supports HTTP(S) URLs (asterisk[16])
Friendly Automation
asteriskteam at digium.com
Mon Sep 28 13:20:14 CDT 2020
Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/14938 )
Change subject: res_musiconhold: Clarify that playlist mode only supports HTTP(S) URLs
......................................................................
res_musiconhold: Clarify that playlist mode only supports HTTP(S) URLs
Change-Id: I41e77a04e4a523f4ed61a7a20b738ffd42be441e
---
M configs/samples/musiconhold.conf.sample
M res/res_musiconhold.c
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Benjamin Keith Ford: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved
Friendly Automation: Approved for Submit
diff --git a/configs/samples/musiconhold.conf.sample b/configs/samples/musiconhold.conf.sample
index 1090bbe..2f60108 100644
--- a/configs/samples/musiconhold.conf.sample
+++ b/configs/samples/musiconhold.conf.sample
@@ -13,7 +13,7 @@
; valid mode options:
; files -- read files from a directory in any Asterisk supported
; media format
-; playlist -- provide a fixed list of filenames or URLs to play
+; playlist -- provide a fixed list of filenames or HTTP(S) URLs to play
; quietmp3 -- default
; mp3 -- loud
; mp3nb -- unbuffered
@@ -56,7 +56,7 @@
; Each entry must be one of:
;
; * An absolute path to the file to be played, without an extension.
-; * A URL
+; * An HTTP(S) URL
;
; The entries are played in the order in which they appear in the
; configuration. The 'sort' option is not used for this mode.
diff --git a/res/res_musiconhold.c b/res/res_musiconhold.c
index 46bc4b9..8d1ab2a 100644
--- a/res/res_musiconhold.c
+++ b/res/res_musiconhold.c
@@ -1144,7 +1144,7 @@
AST_VECTOR_APPEND(playlist_entries, dup);
} else {
- ast_log(LOG_ERROR, "Playlist entries must be a URL or absolute path, '%s' provided.\n", var->value);
+ ast_log(LOG_ERROR, "Playlist entries must be an HTTP(S) URL or absolute path, '%s' provided.\n", var->value);
}
} else if (!strcasecmp(var->name, "directory")) {
ast_copy_string(mohclass->dir, var->value, sizeof(mohclass->dir));
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14938
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I41e77a04e4a523f4ed61a7a20b738ffd42be441e
Gerrit-Change-Number: 14938
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200928/f0c5ab85/attachment.html>
More information about the asterisk-code-review
mailing list