[Asterisk-code-review] res_pjsip_session: Fix issue with COLP and 491 (asterisk[certified/16.8])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14894 )

Change subject: res_pjsip_session: Fix issue with COLP and 491
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14894/1/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/14894/1/res/res_pjsip_session.c@2428 
PS1, Line 2428: 				/* If the resulting media state matches the existing active state don't bother doing a session refresh */
It took me many reads of the commit message to truly understand what was going on here. I think this comment should be expanded with an example to make it clearer.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14894
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: Iffd7dd0500301156a566119ebde528d1a9573314
Gerrit-Change-Number: 14894
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 14 Sep 2020 12:50:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200914/0793c415/attachment.html>