[Asterisk-code-review] res_stasis.c: Added video_single option for bridge creation (asterisk[13])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14905 )

Change subject: res_stasis.c: Added video_single option for bridge creation
......................................................................


Patch Set 4:

> Patch Set 4:
> 
> Before this change ARI provided a route to set a specific channel as the video source, putting the bridge into single source video mode. Can you explain the difference between that and what you've done - and what didn't work with that functionality?
Hi Joshua,

Sure, 
This change allows set the flag for single video source when its creating.

And this is reason for why I'm trying to add this changes.

1. It is hard to know the purpose of the bridge if the bridge just created(CreatedBridge ARI event). Something like is this bridge for normal talk? or sigle source? It is possible by parsing the bridge name, but this will make it easier.

And also I was trying to reduce the changes of bridge's type to make my code simpler. But I had to change the bridge's type all the time manually, because of this.

2. If any channel entered to the bridge, without video source option, it just starting to streaming the video immediately...


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14905
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I43e720e5c83fc75fafe10fe22808ae7f055da2ae
Gerrit-Change-Number: 14905
Gerrit-PatchSet: 4
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 02 Sep 2020 11:08:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200902/23dd5cf1/attachment.html>