[Asterisk-code-review] res_pjsip_diversion: implement support for History-Info (asterisk[16])

[Torrey Searle]

Torrey Searle has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14729 )

Change subject: res_pjsip_diversion: implement support for History-Info
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14729/10/res/res_pjsip_diversion.c 
File res/res_pjsip_diversion.c:

https://gerrit.asterisk.org/c/asterisk/+/14729/10/res/res_pjsip_diversion.c@654 
PS10, Line 654: 		add_supported(tdata);
> Don't we have to add the Supported attribute on _all_ outgoing invites so that the UAS knows that we […]
if the leg doesn't have history_info enabled, then it should be considered as no supported I would imagine



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14729
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2296369582d4b295c5ea1e60bec391dd1d318fa6
Gerrit-Change-Number: 14729
Gerrit-PatchSet: 10
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 01 Sep 2020 13:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200901/6b016af3/attachment.html>