[Asterisk-code-review] chan_sip: On authentication, pick MD5 for sure. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15096 )

Change subject: chan_sip: On authentication, pick MD5 for sure.
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> > Let us know when they do.
> 
> They want to avoid the re-peated line:
> const pj_str_t pjsip_AKAv1_MD5_STR = { "AKAv1-MD5", 9 };
> but break the return codes instead. I do not think that is going to be acceptable for Asterisk either. Furthermore, I do not understand their proposal and what it all changes. They "accept" mine but just do not like that re-peated const, as far as I understand them for code style purposes. On the other hand, they have no problem to break the return codes. Go figure!
> 
> Furthermore, the issue is open for months with them. I did everything I can do. At least I have no idea what else I should do with them. If you do not accept this because Teluu is blocking this (and I do not know why they block) then what about removing the PJSIP part here and I fix at least chan_sip?
> 
> I just fixed in PJSIP because of symmetry reasons. Is it really my job not only to fix branches I do not use, but also fix (convince, understand, and be more clever) the whole world? Just to repeat, this is not a feature request but a bug since day one, stopping the future wide-spread of security in SIP authentication.

That's weird.  If you want to forward the email chain to us (asteriskteam at digium.com) maybe we can help sort things out.  In the mean time, yeah let's go forward with just the chan_sip change.  Thanks for trying!


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15096
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I61ca0b1f74b5ec2b5f3062c2d661cafeaf597fcd
Gerrit-Change-Number: 15096
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 11:16:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201029/aaa2be91/attachment.html>