[Asterisk-code-review] tcptls.c: Don't close TCP client file descriptors more than once (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15024 )

Change subject: tcptls.c: Don't close TCP client file descriptors more than once
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1: Code-Review-1
> > 
> > Not quite sure about this change.  ast_tcptls_client_create() and ast_tcptls_client_start() are public APIs and we're changing their behavior.  app_externalivr and res_http_websocket don't appear to do their own closes on failures in client_create() of client_start().
> 
> The tcptls.c code will close the fd before the iostream is created and the iostream code will close the fd after the iostream is created. Feel free to test for yourself.

I see that for websocket  now but humor me and check app_externalivr.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15024
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ib556b0a0c95cca939e956886214ec8d828d89606
Gerrit-Change-Number: 15024
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 02 Oct 2020 18:08:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201002/21303c0b/attachment.html>